feat(ic-ledger-types): Add AccountIdentifier.as_bytes() #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitdivine
commented
Sep 25, 2024
| #[test] | ||
| fn check_round_trip() { | ||
| fn check_hex_round_trip() { |
There was a problem hiding this comment.
Renamed to avoid ambiguity around hex/bytes round trip.
bitdivine
commented
Sep 25, 2024
| /// Provide the account identifier as bytes. | ||
| pub fn as_bytes(&self) -> &[u8; 32] { | ||
| &self.0 | ||
| } |
There was a problem hiding this comment.
Note: The constructor takes great care to make sure that the checksum is valid, so this method is provided, rather than making the inner value public and compromising the integrity checks.
A fixed length array is returned rather than a slice, as otherwise the caller has no guarantee that the length is correct.
adamspofford-dfinity
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is currently not possible to obtain an
AccountIdentifieras bytes. It is only possible to obtain hex and then convert the hex back to bytes. This is resolved by adding an.as_bytes()method that returns a reference to the inner bytes.Fixes #519
How Has This Been Tested?
A unit test is included that verifies that parsing bytes and returning them as bytes yields the original data.
Checklist: